Plugin State Converter rework #454
Conversation
…onversion Done together with Roelof
| clap_id src_param_id, | ||
| clap_id *dst_param_ids, | ||
| uint32_t dst_param_ids_size); | ||
|
|
There was a problem hiding this comment.
get_mapping is reduntant I think? convert_value can do this already.
| uint32_t flags, | ||
| clap_plugin_state_converter_param_value_t *src, | ||
| clap_plugin_state_converter_param_value_t *dsts, | ||
| uint32_t dsts_size); | ||
| } clap_plugin_state_converter_t; | ||
|
|
There was a problem hiding this comment.
I'd prefer to turn convert_state, get_mapping and convert_value into a single function:
int32_t(CLAP_ABI *convert)(struct clap_plugin_state_converter *converter,
uint32_t flags,
const clap_istream_t *src,
const clap_ostream_t *dst,
clap_plugin_state_converter_param_value_t *srcs,
uint32_t srcs_count,
clap_plugin_state_converter_param_value_t *dsts,
uint32_t dsts_size);
This avoids the rather ugly "convert_value assumes the state of the plugin to the one from the most recent call to". It also gives plugin developers the whole shebang in one go, so we don't have to change it again when a developer needs to see more than one automation point to be able to do the right thing.
abique
force-pushed
the
next
branch
2 times, most recently
from
eff5302 to
00113aa
Compare
No description provided.